Skip to content

Commit 28a9b4e

Browse files
authored
Merge pull request rnc-archive#25 from stoffern/master
[Android] - Fix compilation issues NDK errors
2 parents 64aa1ce + 790c360 commit 28a9b4e

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ react-native-webgl is implemented with some C++ bricks and `react-native link re
3131

3232
- `android/local.properties`: Make sure you have Android NDK (needed to compile the Native C++ code) and that it's properly configured in ANDROID_NDK env or in `local.properties` file (e.g. `ndk.dir=/usr/local/opt/android-ndk-r10e`).
3333
- `android/build.gradle`: If it's not already there, add `gradle-download-task` **buildscript** dependency: `classpath 'de.undercouch:gradle-download-task:3.1.2'` . If you don't do this, you will likely have `:downloadJSCHeaders` not working.
34+
- `android/app/build.gradle`: Make shure you have `minSdkVersion 17` or higher
3435

3536
## Usage
3637

android/src/main/jni/Application.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ APP_LDFLAGS += -lGLESv2
1717
APP_LDFLAGS += -pthread
1818
APP_LDFLAGS += -ljnigraphics
1919

20-
NDK_TOOLCHAIN_VERSION := 4.8
20+
NDK_TOOLCHAIN_VERSION := 4.9

cpp/RNWebGL.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
#include "JSUtils.h"
2525
#include "JSConvertTypedArray.h"
2626

27+
#include <stdlib.h>
28+
2729
#ifdef __APPLE__
2830
#include "EXiOSUtils.h"
2931
#endif

0 commit comments

Comments
 (0)