Create VLAN interface before DHCPing: #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables creating VLAN interfaces based on the "vlan_id=" value in /proc/cmdline. No VLAN interface will be created if "vlan_id=" does not have a value. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
vlan-support
branch
from
cde6be8 to
27ec830
Compare
Boots send kernel command line parameter "ip=dhcp", this causes the system to configure the network interface(s) with DHCP. When an environment's network configuration has this machine connected a trunked interface with a default/native VLAN, the interface will be configured on the default/native VLAN because we haven't yet configured the VLAN interface. Boots will respond to this DHCP request because in this scenario it is not VLAN aware. Also in this scenario, the machine will end up being configured with 2 default routes. To resolve this, we remove the default route and IP that kernel added and let the dhcpcd handle setting the route. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
vlan-support
branch
from
a8240ca to
430f0bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables creating VLAN interfaces based on the
vlan_id=value in/proc/cmdline. No VLAN interface will be created ifvlan_id=does not have a value.Why is this needed
This enables trunk vlan support across the Tink stack. https://github.com/tinkerbell/proposals/blob/main/proposals/0030/README.md
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: