Skip to content

Commit ef976ff

Browse files
Update dockerhub login envs (#211)
## Description <!--- Please describe what this PR is going to change --> ## Why is this needed <!--- Link to issue you have raised --> Fixes: # ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## How are existing users impacted? What migration steps/scripts do we need? <!--- Fixes a bug, unblocks installation, removes a component of the stack etc --> <!--- Requires a DB migration script, etc. --> ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
2 parents acac456 + 3ed6c3f commit ef976ff

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/build-all-matrix.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ env: # Global environment, passed to all jobs & all steps
1414

1515
# Apart from the quay/ghcr coordinates above (used for both pulling & pushing), we might also want to
1616
# log in to DockerHub (with a read-only token) so we aren't hit by rate limits when pulling the linuxkit pkgs.
17-
# To do so, set the secret DOCKER_USERNAME and DOCKER_PASSWORD in the repo secrets, and set the below to yes.
17+
# To do so, set the secret DOCKERHUB_USERNAME and DOCKERHUB_PASSWORD in the repo secrets, and set the below to yes.
1818
LOGIN_TO_DOCKERHUB: "yes"
1919

2020
HOOK_VERSION: "0.9.0-alpha1-build-${{github.run_number}}" # Use a forced Hook version
@@ -129,7 +129,7 @@ jobs:
129129
- name: Docker Login to DockerHub # read-only token, required to be able to pull all the linuxkit pkgs without getting rate limited.
130130
if: ${{ env.LOGIN_TO_DOCKERHUB == 'yes' }}
131131
uses: docker/login-action@v3
132-
with: { registry: "docker.io", username: "${{ secrets.DOCKER_USERNAME }}", password: "${{ secrets.DOCKER_PASSWORD }}" }
132+
with: { registry: "docker.io", username: "${{ secrets.DOCKERHUB_USERNAME }}", password: "${{ secrets.DOCKERHUB_PASSWORD }}" }
133133

134134
- name: Docker Login to quay.io
135135
if: ${{ env.REGISTRY == 'quay.io' }}

0 commit comments

Comments
 (0)