Offer createKey() to register a new API key.#9
Offer createKey() to register a new API key.#9rolftimmermans wants to merge 24 commits intomasterfrom
Conversation
|
Mm.....This commits are too long to read. It should squash them to the less commits when merging this PR. |
…compression count, paying state and email address when they are returned from validate() calls.
| self::$client = NULL; | ||
| } | ||
|
|
||
| public static function getKey() { |
There was a problem hiding this comment.
I think it should use PHP_CodeSniffer or php-cs-fixer to fix PSR-2 coding style.
| function emailAddress() { | ||
| return Tinify::getEmailAddress(); | ||
| } | ||
|
|
There was a problem hiding this comment.
These methods are very strange.
They looks similar. The duplicate should be removed.
… returned from the /keys endpoint.
|
Would love to see this in production! I got two quick questions:
|
|
Hi there! Once we have implemented the same logic for the other libraries we will put this into production and update the documentation.
|
Rebase master on create-key branch
No description provided.