Skip to content

Commit 26cc3b4

Browse files
TanayParikhTanayParikh
authored
Unquarantine Tests (dotnet#23098)
Found a bunch of tests running for 30+ days with 100% pass rate.
1 parent 7b707c9 commit 26cc3b4

File tree

16 files changed

+1
-28
lines changed

16 files changed

+1
-28
lines changed

‎src/Components/Components/test/Rendering/RendererSynchronizationContextTest.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public void Post_RunsAsynchronously_WhenNotBusy()
2626
Thread capturedThread = null;
2727

2828
var e = new ManualResetEventSlim();
29-
29+
3030
// Act
3131
context.Post((_) =>
3232
{
@@ -766,7 +766,6 @@ public async Task InvokeAsync_FuncTaskT_CanReportCancellation()
766766
}
767767

768768
[Fact]
769-
[QuarantinedTest]
770769
public async Task InvokeAsync_SyncWorkInAsyncTaskIsCompletedFirst()
771770
{
772771
// Simplified version of ServerComponentRenderingTest.CanDispatchAsyncWorkToSyncContext

‎src/Identity/Specification.Tests/src/UserManagerSpecificationTests.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1450,7 +1450,6 @@ public async Task ChangePhoneNumberWithCustomProvider()
14501450
/// </summary>
14511451
/// <returns>Task</returns>
14521452
[Fact]
1453-
[QuarantinedTest]
14541453
public async Task ChangePhoneNumberFailsWithWrongPhoneNumber()
14551454
{
14561455
var manager = CreateManager();
@@ -1471,7 +1470,6 @@ public async Task ChangePhoneNumberFailsWithWrongPhoneNumber()
14711470
/// </summary>
14721471
/// <returns>Task</returns>
14731472
[Fact]
1474-
[QuarantinedTest]
14751473
public async Task CanVerifyPhoneNumber()
14761474
{
14771475
var manager = CreateManager();
@@ -1519,7 +1517,6 @@ public async Task CanChangeEmail()
15191517
/// </summary>
15201518
/// <returns>Task</returns>
15211519
[Fact]
1522-
[QuarantinedTest]
15231520
public async Task CanChangeEmailOnlyIfEmailSame()
15241521
{
15251522
var manager = CreateManager();

‎src/Mvc/Mvc.TagHelpers/test/CacheTagHelperTest.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -887,7 +887,6 @@ public async Task ProcessAsync_ThrowsExceptionForAwaiters_IfExecutorEncountersAn
887887
}
888888

889889
[Fact]
890-
[QuarantinedTest]
891890
public async Task ProcessAsync_AwaitersUseTheResultOfExecutor()
892891
{
893892
// Arrange

‎src/Servers/IIS/IIS/test/Common.FunctionalTests/ClientCertificateTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ public static TestMatrix TestVariants
3434
.WithAllHostingModels();
3535

3636
[ConditionalTheory]
37-
[QuarantinedTest]
3837
[MemberData(nameof(TestVariants))]
3938
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8)]
4039
public Task HttpsNoClientCert_NoClientCert(TestVariant variant)

‎src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,6 @@ await ExpectAsync(Http2FrameType.PING,
300300
}
301301

302302
[Fact]
303-
[QuarantinedTest]
304303
public async Task StreamPool_MultipleStreamsInSequence_PooledStreamReused()
305304
{
306305
TaskCompletionSource appDelegateTcs = null;
@@ -365,7 +364,6 @@ await ExpectAsync(Http2FrameType.PING,
365364
}
366365

367366
[Fact]
368-
[QuarantinedTest]
369367
public async Task StreamPool_StreamIsInvalidState_DontReturnedToPool()
370368
{
371369
var serverTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
@@ -4010,7 +4008,6 @@ await ExpectAsync(Http2FrameType.HEADERS,
40104008
[Theory]
40114009
[InlineData(true)]
40124010
[InlineData(false)]
4013-
[QuarantinedTest]
40144011
public async Task CONTINUATION_Received_WithTrailers_Available(bool sendData)
40154012
{
40164013
await InitializeConnectionAsync(_readTrailersApplication);

‎src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2TimeoutTests.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,6 @@ await ExpectAsync(Http2FrameType.DATA,
371371
}
372372

373373
[Fact]
374-
[QuarantinedTest]
375374
public async Task DATA_Sent_TooSlowlyDueToFlowControlOnSmallWrite_AbortsConnectionAfterGracePeriod()
376375
{
377376
var mockSystemClock = _serviceContext.MockSystemClock;
@@ -426,7 +425,6 @@ await WaitForConnectionErrorAsync<ConnectionAbortedException>(
426425
}
427426

428427
[Fact]
429-
[QuarantinedTest]
430428
public async Task DATA_Sent_TooSlowlyDueToOutputFlowControlOnLargeWrite_AbortsConnectionAfterRateTimeout()
431429
{
432430
var mockSystemClock = _serviceContext.MockSystemClock;

‎src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,6 @@ await sslStream.AuthenticateAsClientAsync("127.0.0.1", clientCertificates: null,
220220

221221
[Fact]
222222
[Repeat(20)]
223-
[QuarantinedTest]
224223
public async Task DoesNotThrowObjectDisposedExceptionFromWriteAsyncAfterConnectionIsAborted()
225224
{
226225
var tcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);

‎src/Servers/Kestrel/test/InMemory.FunctionalTests/RequestHeaderLimitsTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ public class RequestHeaderLimitsTests : LoggedTest
2323
[InlineData(5, 0)]
2424
[InlineData(5, 1)]
2525
[InlineData(5, 1337)]
26-
[QuarantinedTest]
2726
public async Task ServerAcceptsRequestWithHeaderTotalSizeWithinLimit(int headerCount, int extraLimit)
2827
{
2928
var headers = MakeHeaders(headerCount);

‎src/Servers/Kestrel/test/InMemory.FunctionalTests/RequestTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,6 @@ public async Task AppCanSetTraceIdentifier()
559559
}
560560

561561
[Fact]
562-
[QuarantinedTest]
563562
public async Task TraceIdentifierIsUnique()
564563
{
565564
const int identifierLength = 22;

‎src/SignalR/clients/csharp/Client/test/UnitTests/TimerAwaitableTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ namespace Microsoft.AspNetCore.SignalR.Client.Tests
1313
public class TimerAwaitableTests
1414
{
1515
[Fact]
16-
[QuarantinedTest]
1716
public async Task FinalizerRunsIfTimerAwaitableReferencesObject()
1817
{
1918
var tcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);

‎src/Tools/dotnet-watch/test/AppWithDepsTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ public AppWithDepsTests(ITestOutputHelper logger)
2020
}
2121

2222
[Fact]
23-
[QuarantinedTest]
2423
public async Task ChangeFileInDependency()
2524
{
2625
await _app.StartWatcherAsync();

‎src/Tools/dotnet-watch/test/DotNetWatcherTests.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ public DotNetWatcherTests(ITestOutputHelper logger)
2323
}
2424

2525
[Fact]
26-
[QuarantinedTest]
2726
public async Task RunsWithDotnetWatchEnvVariable()
2827
{
2928
Assert.True(string.IsNullOrEmpty(Environment.GetEnvironmentVariable("DOTNET_WATCH")), "DOTNET_WATCH cannot be set already when this test is running");
@@ -36,7 +35,6 @@ public async Task RunsWithDotnetWatchEnvVariable()
3635
}
3736

3837
[Fact]
39-
[QuarantinedTest]
4038
public async Task RunsWithIterationEnvVariable()
4139
{
4240
await _app.StartWatcherAsync();

‎src/Tools/dotnet-watch/test/GlobbingAppTests.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ public GlobbingAppTests(ITestOutputHelper logger)
2424
[Theory]
2525
[InlineData(true)]
2626
[InlineData(false)]
27-
[QuarantinedTest]
2827
public async Task ChangeCompiledFile(bool usePollingWatcher)
2928
{
3029
_app.UsePollingWatcher = usePollingWatcher;
@@ -43,7 +42,6 @@ public async Task ChangeCompiledFile(bool usePollingWatcher)
4342
}
4443

4544
[Fact]
46-
[QuarantinedTest]
4745
public async Task DeleteCompiledFile()
4846
{
4947
await _app.StartWatcherAsync();
@@ -60,7 +58,6 @@ public async Task DeleteCompiledFile()
6058
}
6159

6260
[Fact]
63-
[QuarantinedTest]
6461
public async Task DeleteSourceFolder()
6562
{
6663
await _app.StartWatcherAsync();
@@ -77,7 +74,6 @@ public async Task DeleteSourceFolder()
7774
}
7875

7976
[Fact]
80-
[QuarantinedTest]
8177
public async Task RenameCompiledFile()
8278
{
8379
await _app.StartWatcherAsync();
@@ -90,7 +86,6 @@ public async Task RenameCompiledFile()
9086
}
9187

9288
[Fact]
93-
[QuarantinedTest]
9489
public async Task ChangeExcludedFile()
9590
{
9691
await _app.StartWatcherAsync();

‎src/Tools/dotnet-watch/test/MsBuildFileSetFactoryTest.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ public async Task ExcludesDefaultItemsWithWatchFalseMetadata()
7777
}
7878

7979
[Fact]
80-
[QuarantinedTest]
8180
public async Task SingleTfm()
8281
{
8382
_tempDir

‎src/Tools/dotnet-watch/test/NoDepsAppTests.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ public NoDepsAppTests(ITestOutputHelper logger)
2424
}
2525

2626
[Fact]
27-
[QuarantinedTest]
2827
public async Task RestartProcessOnFileChange()
2928
{
3029
await _app.StartWatcherAsync(new[] { "--no-exit" });
@@ -43,7 +42,6 @@ public async Task RestartProcessOnFileChange()
4342
}
4443

4544
[Fact]
46-
[QuarantinedTest]
4745
public async Task RestartProcessThatTerminatesAfterFileChange()
4846
{
4947
await _app.StartWatcherAsync();

‎src/Tools/dotnet-watch/test/ProgramTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ public ProgramTests(ITestOutputHelper output)
2424
}
2525

2626
[Fact]
27-
[QuarantinedTest]
2827
public async Task ConsoleCancelKey()
2928
{
3029
_tempDir

0 commit comments

Comments
 (0)