Skip to content

gh-275: Propagate exceptions as a RuntimeException instead of java.lang.Error #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2018
Merged

gh-275: Propagate exceptions as a RuntimeException instead of java.lang.Error #281

merged 1 commit into from
Jan 5, 2018

Conversation

mjpitz
Copy link
Contributor

@mjpitz mjpitz commented Jan 5, 2018

This should make it so that consumers can catch an Exception instead of any Error type.

@mjpitz mjpitz mentioned this pull request Jan 5, 2018
Closed
@timols
Copy link
Owner

timols commented Jan 5, 2018

Easy. I thought you were going to create a new exception class. This works too :)

@timols timols merged commit 1b3dae4 into timols:master Jan 5, 2018
@islandsvinur
Copy link
Contributor

Got hit by an Error today (was still on 4.0.0), upgraded to 4.1.0, then got hit again by a generic RuntimeException. Glad it no longer kills my thread, but I would prefer the API to throw IOException as declared. Maybe wrap it here in UncheckedIOException, then unwrap and rethrow?

@timols I'll create an issue

@islandsvinur islandsvinur mentioned this pull request Feb 14, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjpitz @timols @islandsvinur