Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to get the docs deploying #117

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Try to get the docs deploying #117

merged 2 commits into from
Jul 1, 2020

Conversation

timholy
Copy link
Owner

@timholy timholy commented Jul 1, 2020

For some reason the docs haven't deployed since 1.5. This run suggests, if anything, that it's due to a lack of push_preview (though that seems weird). Let's try this, though, and see if it fixes it.

@aminya
Copy link
Contributor

aminya commented Jul 1, 2020

Did you add the proper keys?

julia> using DocumenterTools, SnoopCompile
julia> DocumenterTools.genkeys(SnoopCompile)

@timholy
Copy link
Owner Author

timholy commented Jul 1, 2020

Yes, you can see it found the keys from the logs:

│ - ✔ ENV["DOCUMENTER_KEY"] exists exists

@timholy
Copy link
Owner Author

timholy commented Jul 1, 2020

https://timholy.github.io/SnoopCompile.jl/previews/PR117

@aminya
Copy link
Contributor

aminya commented Jul 1, 2020

What happens if you run the script offline manually?

@timholy
Copy link
Owner Author

timholy commented Jul 1, 2020

Works fine. (I always do that whenever working on the docs.)

@timholy
Copy link
Owner Author

timholy commented Jul 1, 2020

You get some warnings when you do so, we'll have that until JuliaDocs/Documenter.jl#1352 merges and gets released.

@aminya
Copy link
Contributor

aminya commented Jul 1, 2020

I think it is better to test this on the master instead. Merge it there and see if the docs get updated.

@timholy timholy merged commit 0a2341a into master Jul 1, 2020
@timholy timholy deleted the teh/docs branch July 1, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants