Add MethodInstance subtyping #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo:
```
julia> methodinstances(convert, (Type{Bool}, Real))
2-element Vector{Core.MethodInstance}:
MethodInstance for convert(::Type{Bool}, ::Bool)
MethodInstance for convert(::Type{Bool}, ::Int64)
```
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
- Coverage 94.11% 93.97% -0.15%
==========================================
Files 4 4
Lines 306 332 +26
==========================================
+ Hits 288 312 +24
- Misses 18 20 +2
Continue to review full report at Codecov.
|
As often happens, this discovered a bug on some Julia versions.
timholy
added a commit
to timholy/SnoopCompile.jl
that referenced
this pull request
Feb 15, 2022
Formerly this seemed to return a single MethodInstance, but now it returns two. The change is may be from improvements to MethodAnalysis, likely timholy/MethodAnalysis.jl#27. The new behavior is certainly the correct one (there are two distinct methods, so there had better be two MethodInstances with that signature---even though one will never get another CodeInstance).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: