Fix warnings and lints (#5)

Author: timfish

Cargo.toml

@@ -6,7 +6,7 @@ license = "MIT"
 name = "usb_enumeration"
 readme = "README.md"
 repository = "https://github.com/meatysolutions/usb_enumeration"
-version = "0.1.2"
+version = "0.2.0"
 
 [lib]
 crate-type = ["lib"]

src/lib.rs

@@ -113,7 +113,7 @@ pub struct Subscription {
     pub rx_event: Receiver<Event>,
     // When this gets dropped, the channel will become disconnected and the
     // background thread will close
-    tx_close: Sender<()>,
+    _tx_close: Sender<()>,
 }
 
 #[derive(Debug, Clone)]
@@ -197,7 +197,7 @@ impl Observer {
 
                         // Send Disconnect for missing devices
                         for device in &device_list {
-                            if !next_devices.contains(&device)
+                            if !next_devices.contains(device)
                                 && tx_event.send(Event::Disconnect(device.clone())).is_err()
                             {
                                 return;
@@ -206,7 +206,7 @@ impl Observer {
 
                         // Send Connect for new devices
                         for device in &next_devices {
-                            if !device_list.contains(&device)
+                            if !device_list.contains(device)
                                 && tx_event.send(Event::Connect(device.clone())).is_err()
                             {
                                 return;
@@ -219,7 +219,10 @@ impl Observer {
             })
             .expect("Could not spawn background thread");
 
-        Subscription { rx_event, tx_close }
+        Subscription {
+            rx_event,
+            _tx_close: tx_close,
+        }
     }
 }
 

src/macos.rs

@@ -26,10 +26,16 @@ pub fn enumerate_platform(vid: Option<u16>, pid: Option<u16>) -> Vec<UsbDevice>
         #[allow(clippy::unit_cmp)]
         while (device = IOIteratorNext(iter)) == () && device > 0 {
             #[allow(clippy::uninit_assumed_init)]
-            let mut props: CFMutableDictionaryRef = MaybeUninit::uninit().assume_init();
+            let mut props = MaybeUninit::<CFMutableDictionaryRef>::uninit();
 
-            let _result =
-                IORegistryEntryCreateCFProperties(device, &mut props, kCFAllocatorDefault, 0);
+            let _result = IORegistryEntryCreateCFProperties(
+                device,
+                props.as_mut_ptr(),
+                kCFAllocatorDefault,
+                0,
+            );
+
+            let props = props.assume_init();
 
             let properties: CFDictionary<CFString, CFType> =
                 CFMutableDictionary::wrap_under_get_rule(props).to_immutable();