This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Add telemetry for metrics_ingestion_path & json_endpoint_used
#1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VineethReddy02 for new telemetry information. |
Harkishen-Singh
force-pushed
the
more_telemetry_points
branch
2 times, most recently
from
ec582e0
to
6eaf1fe
Compare
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
Harkishen-Singh
force-pushed
the
more_telemetry_points
branch
from
6eaf1fe
to
d6b1d51
Compare
| case "application/openmetrics-text": | ||
| telemetry.Registry.Update("metrics_ingestion_path", "text_open_metrics") | ||
| default: | ||
| telemetry.Registry.Update("metrics_ingestion_path", "none") |
There was a problem hiding this comment.
Nit: unknown seems better
| @@ -124,17 +93,17 @@ func (m *Manager) getReloader(cfg *Config) func() error { | |||
|
|
|||
| func (m *Manager) updateTelemetry(cfg *Config) { | |||
| if cfg.ContainsRules() { | |||
| rulesEnabled.Set(1) | |||
| telemetry.Registry.Update("rules_enabled", "1") | |||
There was a problem hiding this comment.
I am not sure how I feel about these hardcoded strings in various places
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harkishen-Singh harkishensingh@hotmail.com
Relates: #1616
Description
This commit adds telemetry for 2 things:
promscale_metrics_ingestion_path: possible valuesno_ingestionif Promscale is sitting idle, otherwiseprotobuf, json, text_plain, text_open_metricspromscale_metrics_json_endpoint_used:0or1Along with this, the commit also simplifies the Telemetry implementation for binary cases, removing the need to creating any metrics at all. This affects
promscale_rules_enabled&promscale_alerting_enabled.Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: