Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Switch to time-based epoch for series cache #1653

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JamesGuthrie
Copy link
Member

@JamesGuthrie JamesGuthrie commented Sep 19, 2022

Description

This is a companion change to 1. That change modifies the database
schema to switch to a time-based epoch. This change propagates the
time-based epoch into the Promscale connector.

For more details about the rationale behind this change, see 1.

Merge requirements

Please take into account the following non-code changes that you may need to make with your PR:

  • CHANGELOG entry for user-facing changes
  • Updated the relevant documentation

@JamesGuthrie JamesGuthrie force-pushed the jg/time-based-epoch branch 3 times, most recently from 510d0b7 to aff9662 Compare September 20, 2022 16:32
@JamesGuthrie JamesGuthrie changed the title WIP: Switch to time-based epoch Switch to time-based epoch for series cache Sep 20, 2022
@JamesGuthrie JamesGuthrie marked this pull request as ready for review September 20, 2022 16:33
@JamesGuthrie JamesGuthrie requested a review from a team as a code owner September 20, 2022 16:33
@JamesGuthrie JamesGuthrie requested a review from a team September 20, 2022 16:33
Copy link
Contributor

@alejandrodnm alejandrodnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd wait for someone else with more experience with this part of the code to review it before merging. This is the first time I look into this part of the code.

This is a companion change to [1]. That change modifies the database
schema to switch to a time-based epoch. This change propagates the
time-based epoch into the Promscale connector.

For more details about the rationale behind this change, see [1].

[1]: timescale/promscale_extension#512
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants