Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor smoothie charts can't handle NaN #9

Open
jonathanjfshaw opened this issue Mar 28, 2020 · 1 comment
Open

Monitor smoothie charts can't handle NaN #9

jonathanjfshaw opened this issue Mar 28, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@jonathanjfshaw
Copy link

If there are Nan values in a dataframe, and you pipe it to the monitor node, then nothing shows up in the monitor's smoothie chart.

Fixing this in the ui node wuld be trivial with df.dropna(), but it may be better to fix in the monitor's ui.js as some other apps may have uses for NaN values.

@mesca
Copy link
Member

mesca commented Apr 3, 2020

Good catch. I have to investigate if there is an actual JavaScript error or if it simply stops rendering for a while. Removing NaN in JavaScript is costly because you have to loop over every sample. And I am a bit reluctant to remove the problematic samples in the UI node because, as you said, it could be useful in other circumstances (and especially when we will have other widgets). For now, if you know that your data is likely to have NaN, maybe a very light custom node that just do something like: self.o.data = self.i.data.dropna() would be a good alternative? This would have a place in core, I guess.

@mesca mesca added the bug Something isn't working label Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants