Merge pull request #140 from timcadman/dev

timcadman · web-flow · commit 49840e6657d7 · 2024-10-14T10:17:21.000+02:00
fix: corrected formula for pooled se
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: dsHelper
 Type: Package
 Title: Helper Functions for Use with 'DataSHIELD'
-Version: 1.5
+Version: 1.5.1
 Description: Often we need to automate things with 'DataSHIELD'. These functions help to do that.
 Authors@R: 
   c(person(given= "Tim", 
diff --git a/R/pool.R b/R/pool.R
@@ -208,7 +208,7 @@ rubinBetweenVar <- function(coefs, means, m) {
 #'
 #' @noRd
 rubinPooledSe <- function(within_var, between_var, m) {
-  return(within_var + between_var + (between_var / m))
+  return(sqrt(within_var + between_var + (between_var / m)))
 }
 
 #' Calculate the Rubin's Z statistic.

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,7 @@ rubinBetweenVar <- function(coefs, means, m) {`
`208`	`208`	`#'`
`209`	`209`	`#' @noRd`
`210`	`210`	`rubinPooledSe <- function(within_var, between_var, m) {`
`211`		`- return(within_var + between_var + (between_var / m))`
	`211`	`+ return(sqrt(within_var + between_var + (between_var / m)))`
`212`	`212`	`}`
`213`	`213`
`214`	`214`	`#' Calculate the Rubin's Z statistic.`