[10.x] Revival of the reverted changes in 10.25.0: firstOrCreate `u…

…pdateOrCreate` improvement through `createOrFirst` + additional query tests (laravel#48637) * Revert "[10.x] Revert from using `createOrFirst` in other `*OrCreate` methods (laravel#48531)" This reverts commit 408a3e3. * test: 💍 Add `Builder::createOrFirst()` snapshot tests * test: 💍 Add `Builder::firstOrCreate()` snapshot tests * test: 💍 Add `Builder::updateOrCreate()` snapshot tests * test: 💍 Add test stubs for `DatabaseEloquentHasManyTest` * test: 💍 Add `HasMany::createOrFirst()` snapshot tests * test: 💍 Add `HasMany::firstOrCreate()` snapshot tests * test: 💍 Add `HasMany::updateOrCreate()` snapshot tests * test: 💍 prepare HasManyThrough test * test: 💍 Add HasManyThrough::CreateOrFirst() snapshot tests * test: 💍 Add HasManyThrough::firstOrCreate() snapshot test * test: 💍 Add HasManyThrough::updateOrCreate() snapshot test * refactor: 💡 use createOrFirst in firstOrCreate * test: 💍 fix test * style: 💄 Apply StyleCI fixes * docs: ✏️ Add missing FIXME comments * refactor: 💡 Omit verbose arguments * test: 💍 Rename `DatabaseEloquentHasManyThroughTest` with fixes * test: 💍 Add `BelongsToMany::createOrFirst/firstOrCreate` tests * test: 💍 Extract `DatabaseEloquentHasManyTest` cases with fixes * test: 💍 Extract `DatabaseEloquentBuilderTest` cases with fixes * test: 💍 refactoring * test: 💍 Add `BelongsToMany::updateOrCreate` snapshot tests --------- Co-authored-by: fuwasegu <admin@fuwasegu.com>
timacdonald · Oct 24, 2023 · 12e07c0 · 12e07c0
1 parent 107023c
commit 12e07c0
Show file tree

Hide file tree

Showing 10 changed files with 1,670 additions and 33 deletions.
diff --git a/src/Illuminate/Database/Eloquent/Builder.php b/src/Illuminate/Database/Eloquent/Builder.php
@@ -567,7 +567,7 @@ public function firstOrCreate(array $attributes = [], array $values = [])
             return $instance;
         }
 
-        return $this->create(array_merge($attributes, $values));
+        return $this->createOrFirst($attributes, $values);
     }
 
     /**
@@ -595,8 +595,10 @@ public function createOrFirst(array $attributes = [], array $values = [])
      */
     public function updateOrCreate(array $attributes, array $values = [])
     {
-        return tap($this->firstOrNew($attributes), function ($instance) use ($values) {
-            $instance->fill($values)->save();
+        return tap($this->firstOrCreate($attributes, $values), function ($instance) use ($values) {
+            if (! $instance->wasRecentlyCreated) {
+                $instance->fill($values)->save();
+            }
         });
     }
 

diff --git a/src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php b/src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php
@@ -622,7 +622,7 @@ public function firstOrCreate(array $attributes = [], array $values = [], array
     {
         if (is_null($instance = (clone $this)->where($attributes)->first())) {
             if (is_null($instance = $this->related->where($attributes)->first())) {
-                $instance = $this->create(array_merge($attributes, $values), $joining, $touch);
+                $instance = $this->createOrFirst($attributes, $values, $joining, $touch);
             } else {
                 try {
                     $this->getQuery()->withSavepointIfNeeded(fn () => $this->attach($instance, $joining, $touch));
@@ -672,19 +672,13 @@ public function createOrFirst(array $attributes = [], array $values = [], array
      */
     public function updateOrCreate(array $attributes, array $values = [], array $joining = [], $touch = true)
     {
-        if (is_null($instance = (clone $this)->where($attributes)->first())) {
-            if (is_null($instance = $this->related->where($attributes)->first())) {
-                return $this->create(array_merge($attributes, $values), $joining, $touch);
-            } else {
-                $this->attach($instance, $joining, $touch);
-            }
-        }
-
-        $instance->fill($values);
+        return tap($this->firstOrCreate($attributes, $values, $joining, $touch), function ($instance) use ($values) {
+            if (! $instance->wasRecentlyCreated) {
+                $instance->fill($values);
 
-        $instance->save(['touch' => false]);
-
-        return $instance;
+                $instance->save(['touch' => false]);
+            }
+        });
     }
 
     /**

diff --git a/src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php b/src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php
@@ -277,7 +277,7 @@ public function firstOrCreate(array $attributes = [], array $values = [])
             return $instance;
         }
 
-        return $this->create(array_merge($attributes, $values));
+        return $this->createOrFirst(array_merge($attributes, $values));
     }
 
     /**
@@ -305,11 +305,11 @@ public function createOrFirst(array $attributes = [], array $values = [])
      */
     public function updateOrCreate(array $attributes, array $values = [])
     {
-        $instance = $this->firstOrNew($attributes);
-
-        $instance->fill($values)->save();
-
-        return $instance;
+        return tap($this->firstOrCreate($attributes, $values), function ($instance) use ($values) {
+            if (! $instance->wasRecentlyCreated) {
+                $instance->fill($values)->save();
+            }
+        });
     }
 
     /**

diff --git a/src/Illuminate/Database/Eloquent/Relations/HasOneOrMany.php b/src/Illuminate/Database/Eloquent/Relations/HasOneOrMany.php
@@ -236,7 +236,7 @@ public function firstOrNew(array $attributes = [], array $values = [])
     public function firstOrCreate(array $attributes = [], array $values = [])
     {
         if (is_null($instance = $this->where($attributes)->first())) {
-            $instance = $this->create(array_merge($attributes, $values));
+            $instance = $this->createOrFirst($attributes, $values);
         }
 
         return $instance;
@@ -267,10 +267,10 @@ public function createOrFirst(array $attributes = [], array $values = [])
      */
     public function updateOrCreate(array $attributes, array $values = [])
     {
-        return tap($this->firstOrNew($attributes), function ($instance) use ($values) {
-            $instance->fill($values);
-
-            $instance->save();
+        return tap($this->firstOrCreate($attributes, $values), function ($instance) use ($values) {
+            if (! $instance->wasRecentlyCreated) {
+                $instance->fill($values)->save();
+            }
         });
     }