Patch Companions C02 "Brotherhood" (induction) so member does not hang#855
Open
rfortier wants to merge 1 commit intotiltedphoques:devfrom
Open
Patch Companions C02 "Brotherhood" (induction) so member does not hang#855rfortier wants to merge 1 commit intotiltedphoques:devfrom
rfortier wants to merge 1 commit intotiltedphoques:devfrom
Conversation
Patches the single Scene in the quest to fix the hang if a member (not Leader) steps on the ceremony hotspot. The fix is innocuous to the standard game. It was an obscure bug. There's a hidden (not in the the quest log, a bit of an easter egg) objective to speak to the QuestGiver (Vilkas) before going to the ceremony. IF the Leader does not talk to Vilkas AND the member steps on the ceremony hotspot AND the Leader does not stop on the hotspot Scene would hang, so the quest would hang with player controls frozen. The reason is the scene required Vilkas to be present. The hidden objective makes him be present. If the Leader triggered the ceremony (or joins it), Vilkas is told to run to the ceremony. If Member triggered it, well, Vilkas did nothing because he's controlled by Leader. Isn't this fun? Anyway, fixed it by only requiring always-present NPCs to speak their last line. Separate topic: I made this as a separte ESL-flagged ESP. I think now that ESLs exist and are cheap, not burning slots, it makes more senses to keep patches separate rather than bundling them all into one ESP and losing context of what is changing what. But that's debatable, so if there are strong arguments to merge every patch into one .ESP glob, let's hear them.
Collaborator
|
I vote for having a single central TiltedEvolution/Code/client/Services/Generic/DiscoveryService.cpp Lines 257 to 259 in 97e9d28 upd. Spriggit is something to consider (in the future) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patches the single Scene in the quest to fix the hang if a member (not Leader) steps on the ceremony hotspot. The fix is innocuous to the standard game.
It was an obscure bug. There's a hidden (not in the the quest log, a bit of an easter egg) objective to speak to the QuestGiver (Vilkas) before going to the ceremony.
IF the Leader does not talk to Vilkas
AND the member steps on the ceremony hotspot
AND the Leader does not step on the hotspot
Scene would hang, so the quest would hang with player controls frozen. The reason is the scene required Vilkas to be present. The hidden objective makes him be present. If the Leader triggered the ceremony (or joins it), Vilkas is told to run to the ceremony.
If Member triggered it, well, Vilkas did nothing because he's controlled by Leader.
Isn't this fun? Anyway, fixed it by only requiring always-present NPCs to speak their last line.
Separate topic: I made this as a separate ESL-flagged ESP. I think now that ESLs exist and are cheap, not burning slots, it makes more sense to keep patches separate rather than bundling them all into one ESP glob and losing context of what is changing what.
But that's debatable, so if there are strong arguments to merge every patch into one .ESP glob, let's hear them.