Skip to content

readme: add docs #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2020
Merged

readme: add docs #34

merged 1 commit into from
Nov 5, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Nov 5, 2020

Hello @maiamcc,

Please review the following commits I made in branch nicks/install:

a8427bf (2020-11-05 12:20:17 -0500)
readme: add docs

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from maiamcc November 5, 2020 17:20
Copy link

@maiamcc maiamcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

- Docker for Mac
- [KIND](https://kind.sigs.k8s.io/)
- [KIND with a registry](https://kind.sigs.k8s.io/docs/user/local-registry/)
- Allocating CPUs
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only support this for D4M, right? i might nest this stuff:

- Docker for Mac
  - Allocating CPUs
- KIND
  - local registry

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KIND runs in Docker for Mac! So it totally makes sense to have KIND with minCPUs, it will just set the Docker for Mac CPUs

@nicks nicks merged commit 8aea6f7 into main Nov 5, 2020
@nicks nicks deleted the nicks/install branch November 5, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants