Skip to content

Commit fd3a2a8

Browse files
committed
Merge pull request php-curl-class#245 from zachborboa/master
Close MultiCurl resource only when still open
2 parents 1765968 + e70228c commit fd3a2a8

File tree

3 files changed

+14
-2
lines changed

3 files changed

+14
-2
lines changed

src/Curl/Curl.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
class Curl
66
{
7-
const VERSION = '4.7.0';
7+
const VERSION = '4.7.1';
88
const DEFAULT_TIMEOUT = 30;
99

1010
public $curl;

src/Curl/MultiCurl.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,9 @@ public function close()
261261
$ch->close();
262262
}
263263

264-
curl_multi_close($this->multiCurl);
264+
if (is_resource($this->multiCurl)) {
265+
curl_multi_close($this->multiCurl);
266+
}
265267
}
266268

267269
/**

tests/PHPCurlClass/PHPMultiCurlClassTest.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1988,4 +1988,14 @@ public function testAddRequestAfterStart() {
19881988
$this->assertTrue(in_array($url, $urls_called, true));
19891989
}
19901990
}
1991+
1992+
public function testClose()
1993+
{
1994+
$multi_curl = new MultiCurl();
1995+
$multi_curl->addGet(Test::TEST_URL);
1996+
$multi_curl->start();
1997+
$this->assertTrue(is_resource($multi_curl->multiCurl));
1998+
$multi_curl->close();
1999+
$this->assertFalse(is_resource($multi_curl->multiCurl));
2000+
}
19912001
}

0 commit comments

Comments
 (0)