Skip to content

Commit 1cd259c

Browse files
authored
Disable broken integ tests (#2105)
1 parent 74b1c82 commit 1cd259c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+232
-15
lines changed

docs/TESTS.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,3 +99,6 @@ Additionally, optional arguments can be provided to `load_fixtures`:
9999
* `simplify=...` generalises the geometry to the tolerance given as the argument. This is also useful for reducing the size of fixtures and the complexity of the processing when the test does not need the geometry to be accurate.
100100

101101
NOTE: z/x/y coordinates [are describing location and zoom level](https://mapzen.com/documentation/vector-tiles/use-service/#specify-z-x-and-y-tile-coordinates).
102+
103+
## Skipped Tests
104+
There are some broken tests that we skip with the `@unittest.skip(BROKEN)` decorator. Once these tests are fixed, we can remove the decorators.

integration-test/1082-common.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
# -*- encoding: utf-8 -*-
2+
import unittest
3+
4+
from . import BROKEN
25
from . import FixtureTest
36

47

58
class CommonTest(FixtureTest):
6-
9+
@unittest.skip(BROKEN)
710
def test_blithedale_summit_landuse(self):
811
import dsl
912

integration-test/1170-very-early-paths-and-bike-routes.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
11
# -*- encoding: utf-8 -*-
2+
import unittest
3+
4+
from . import BROKEN
25
from . import FixtureTest
36

47

58
class VeryEarlyPathsAndBikeRoutes(FixtureTest):
69

10+
@unittest.skip(BROKEN)
711
def test_path_with_international_route(self):
812
# highway=path, with route inter-national
913
# GR5-Grand Traverse de Jura between France and Switzerland
@@ -36,6 +40,7 @@ def test_path_with_international_route(self):
3640
9, 265, 179, 'roads',
3741
{'kind': 'path', 'walking_network': 'iwn'})
3842

43+
@unittest.skip(BROKEN)
3944
def test_path_with_national_route(self):
4045
# highway=path, with route national (Pacific Crest Trail) at zoom 9
4146
# self.load_fixtures([
@@ -86,6 +91,7 @@ def test_path_with_regional_route(self):
8691
11, 343, 792, 'roads',
8792
{'kind': 'path', 'walking_network': 'rwn'})
8893

94+
@unittest.skip(BROKEN)
8995
def test_unclassified_with_local_route(self):
9096
# highway=unclassified, with route local (Grant Avenue) at zoom 12
9197
# part of The Barbary Coast Trail in San Francisco
@@ -98,6 +104,7 @@ def test_unclassified_with_local_route(self):
98104
12, 655, 1582, 'roads',
99105
{'kind': 'minor_road', 'walking_network': 'lwn'})
100106

107+
@unittest.skip(BROKEN)
101108
def test_secondary_with_international_route(self):
102109
# Strøby Bygade secondary road part of international cycle network
103110
# https://www.openstreetmap.org/relation/28441
@@ -120,6 +127,7 @@ def test_secondary_with_international_route(self):
120127
{'kind': 'major_road', 'kind_detail': 'secondary',
121128
'is_bicycle_related': True, 'bicycle_network': 'icn'})
122129

130+
@unittest.skip(BROKEN)
123131
def test_teriary_with_national_route(self):
124132
# Sundbylillevej tertiary road part of national cycle network
125133
self.load_fixtures([
@@ -132,6 +140,7 @@ def test_teriary_with_national_route(self):
132140
{'kind': 'major_road', 'kind_detail': 'tertiary',
133141
'is_bicycle_related': True, 'bicycle_network': 'ncn'})
134142

143+
@unittest.skip(BROKEN)
135144
def test_cycleway_with_international_route(self):
136145
# Way: North Sea Cycle Route - part Netherlands (1977662)
137146
# A really long highway=cycleway
@@ -203,6 +212,7 @@ def test_cycleway_with_international_route(self):
203212
{'kind': 'path', 'is_bicycle_related': True,
204213
'bicycle_network': 'icn'})
205214

215+
@unittest.skip(BROKEN)
206216
def test_ferry_with_international_route(self):
207217
# Ferry between Denmark and Germany, icn
208218
self.load_fixtures([
@@ -215,6 +225,7 @@ def test_ferry_with_international_route(self):
215225
{'kind': 'ferry', 'is_bicycle_related': True,
216226
'bicycle_network': 'icn'})
217227

228+
@unittest.skip(BROKEN)
218229
def test_minor_road_with_national_route(self):
219230
# Søndervangsvej minor road in Denmark as national cycle route
220231
self.load_fixtures([
@@ -247,6 +258,7 @@ def test_bay_trail_rcn(self):
247258
{'kind': 'path', 'is_bicycle_related': True,
248259
'bicycle_network': type(None)})
249260

261+
@unittest.skip(BROKEN)
250262
def test_residential_with_regional_route(self):
251263
# Hyltebjerg Allé residential road with rcn in Copenhagen
252264
self.load_fixtures([

integration-test/1178-earlier-piers.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
11
# -*- encoding: utf-8 -*-
2+
import unittest
3+
24
import dsl
35
from shapely.wkt import loads as wkt_loads
46

7+
from . import BROKEN
58
from . import FixtureTest
69

710

11+
@unittest.skip(BROKEN)
812
class EarlierPiers(FixtureTest):
913

1014
def test_very_large_pier(self):

integration-test/1194-bus-route-refs.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
1+
import unittest
2+
13
import dsl
2-
from shapely.wkt import loads as wkt_loads
34

5+
from . import BROKEN
46
from . import FixtureTest
57

68

9+
@unittest.skip(BROKEN)
710
class BusRouteRefs(FixtureTest):
811
def test_one_bus_route(self):
912
# Sloat Blvd, part of:

integration-test/1250-early-unclassified-roads.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
11
# -*- encoding: utf-8 -*-
2+
import unittest
3+
24
import dsl
35
from shapely.wkt import loads as wkt_loads
46

7+
from . import BROKEN
58
from . import FixtureTest
69

710

11+
@unittest.skip(BROKEN)
812
class EarlyUnclassifiedRoads(FixtureTest):
913

1014
def test_early_unclassified_road1_utah(self):

integration-test/1252-roads-surface.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
11
# -*- encoding: utf-8 -*-
2+
import unittest
3+
4+
from . import BROKEN
25
from . import FixtureTest
36

47

58
class RoadsSurface(FixtureTest):
9+
@unittest.skip(BROKEN)
610
def test_cobblestones(self):
711
# Add surface properties to roads layer (at max zooms)
812
# Prince St with cobblestones in Alexandria, VA
@@ -30,6 +34,7 @@ def test_asphalt(self):
3034
7, 71, 43, 'roads',
3135
{'kind_detail': 'motorway', 'surface': 'asphalt'})
3236

37+
@unittest.skip(BROKEN)
3338
def test_concrete_lanes(self):
3439
# track with cycling route in Schartau, Germany
3540
# http://www.openstreetmap.org/way/58691615

integration-test/1259-add-grassland-polygons.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
# -*- encoding: utf-8 -*-
2+
import unittest
3+
4+
from . import BROKEN
25
from . import FixtureTest
36

47

@@ -104,6 +107,7 @@ def test_bare_rock(self):
104107
'kind': 'bare_rock',
105108
})
106109

110+
@unittest.skip(BROKEN)
107111
def test_desert(self):
108112
import dsl
109113

integration-test/1273-roads-access.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
# -*- encoding: utf-8 -*-
2+
import unittest
3+
24
import dsl
35
from shapely.wkt import loads as wkt_loads
46

7+
from . import BROKEN
58
from . import FixtureTest
69

710

811
class RoadsAccess(FixtureTest):
9-
12+
@unittest.skip(BROKEN)
1013
def test_restricted_access(self):
1114
# Add surface properties to roads layer (at max zooms)
1215
# restricted access road in military base, Kraków, Poland

integration-test/1298-missing-road.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
1+
import unittest
2+
3+
from . import BROKEN
14
from . import FixtureTest
25

36

7+
@unittest.skip(BROKEN)
48
class MissingRoad(FixtureTest):
59
def test_route_611(self):
610
# Relation: route 611 (975266)

0 commit comments

Comments
 (0)