Pass the tolerance from config through to layer datum. #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `simplify_and_clip` post-processing transform looks in the layer datum to get the tolerance factor to use for simplifying geometries. Turns out, this wasn't getting passed through from the `queries.yaml` config, so it was just using the default of `1.0` for every layer.
iandees
approved these changes
Dec 5, 2018
|
It does, if the YAML contains a float. Otherwise it'll return whatever's in the YAML, which might cause a weird error to bubble up from the simplification step. I've added an explicit conversion to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
simplify_and_clippost-processing transform looks in the layer datum to get the tolerance factor to use for simplifying geometries. Turns out, this wasn't getting passed through from thequeries.yamlconfig, so it was just using the default of1.0for every layer. Ooops.