Use boto3 for tile store #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e issues around accessing S3 buckets in different regions.
…ect ACL. Log bucket and path on S3 errors.
rmarianski
approved these changes
May 3, 2018
| @@ -1979,7 +1979,8 @@ def tilequeue_batch_enqueue(cfg, args): | |||
| logger = make_logger(cfg, 'batch_enqueue') | |||
|
|
|||
| import boto3 | |||
| client = boto3.client('batch', region_name='us-east-1') | |||
| region_name = os.environ.get('AWS_DEFAULT_REGION', 'us-east-1') | |||
| client = boto3.client('batch', region_name=region_name) | |||
There was a problem hiding this comment.
I would assume that boto3 would automatically check the environment variable for us, but this certainly doesn't hurt.
There was a problem hiding this comment.
I think so too. This was my attempt to keep the default the same as before, as I think that not setting the environment variable would otherwise be an error?
There was a problem hiding this comment.
Ah yea, good point. It does error out if there is no default region set.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the tile store implementation to use
boto3rather thanbotoversion 2. It also has a few random fixes, and extra configuration parameters.us-east-1any more.public-readin Nextzen and this will be the default, but others may wantprivate.