Move intersection to rawr enqueue step #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerebubuth
reviewed
Nov 30, 2017
| if not is_low_zoom: | ||
| did_rawr_tile_gen = True | ||
| try: | ||
| parent = common_parent(coords, self.group_by_zoom) |
There was a problem hiding this comment.
I think we should also do:
assert parent.zoom >= self.group_by_zoom
parent = parent.zoomTo(self.group_by_zoom).container()I feel like there are going to be places in the code where we assume parent is a RAWR tile coordinate, but we'll only get a job for the partial tree and end up with parent.zoom=11 or something like that. What do you think?
There was a problem hiding this comment.
Ooops... I should have looked at the definition of common_parent. That's exactly what it does already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to https://github.com/mapzen/tile-tasks/issues/290