-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdc: fix old value config glitch when changefeeds with different settings connect to one region (#9515) #9565
cdc: fix old value config glitch when changefeeds with different settings connect to one region (#9515) #9565
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@liuzix please accept the invitation then you can push to the cherry-pick pull requests. |
/run-all-tests |
Signed-off-by: Zixiong Liu <liuzixiong@pingcap.com>
2250c9a
to
f629c06
Compare
/cc @leoppro |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/run-all-tests |
/merge |
@NingLin-P: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 6f7fecf
|
/merge |
@NingLin-P: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #9515 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tikv repo: git pr https://github.com/tikv/tikv/pull/9565
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Problem Summary:
When two TiCDC changefeeds connect to the same region, but one changefeed requires old value but the other doesn't, the one that doesn't need old value still receives old value.
What is changed and how it works?
What's Changed: Now we record the old value setting in each
Downstream
and filters the old value appropriately before sinking the events.Related changes
Check List
Tests
Release note