batch-system: increase max batch size #9020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Little-Wallace
changed the title
Little-Wallace
changed the title
BusyJay
approved these changes
Nov 12, 2020
gengliqi
approved these changes
Nov 12, 2020
ti-srebot
approved these changes
Nov 12, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@Little-Wallace merge failed. |
|
/merge |
|
/run-all-tests |
solotzg
pushed a commit
to pingcap/tidb-engine-ext
that referenced
this pull request
Nov 23, 2020
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Little-Wallace bupt2013211450@gmail.com
What problem does this PR solve?
Problem Summary:
If user does not enable
hibernate-regionand there are a lot of region in each TiKV instance(This is a big TiKV cluster), TiKV will process a lot of heartbeat msg. The default value ofmax-batch-sizefor batch-system is too small and it will make TiKV must flush after only processing few msg(256 regions). Too frequently flush operations will block raftstore thread too long in system callfsyncand make the performance of TiKV worse much thanrelease-3.0, in which the default value ofmax-batch-sizeis 1024Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tidb-ansible:Check List
Tests
Release note
apply-max-batch-sizeandstore-max-batch-sizeto 1024.