Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo: upgrade grpcio to v0.4.2 #4023

Merged
merged 3 commits into from
Jan 11, 2019
Merged

Conversation

overvenus
Copy link
Member

What have you changed? (mandatory)

Upgrade grpcio to v0.4.2 which uses the gRPC core library v1.17.2.

What are the type of the changes? (mandatory)

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

Integration tests

Does this PR affect documentation (docs) update? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

@overvenus
Copy link
Member Author

/run-all-tests

zhangjinpeng87
zhangjinpeng87 previously approved these changes Jan 7, 2019
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@overvenus
Copy link
Member Author

/run-all-tests

@siddontang
Copy link
Contributor

Em, seem we will upgrade the cache @zhouqiang-cl

@overvenus
Copy link
Member Author

overvenus commented Jan 8, 2019

The CI dockers dont support EPOLLEXCLUSIVE so tikv fails to start.

uname -a
Linux 86c255c4ee9f 3.10.0-327.22.2.el7.x86_64 #1 SMP Thu Jun 23 17:05:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

@Connor1996 Connor1996 added the component/build Component: Build, Deployment, etc. label Jan 8, 2019
@overvenus
Copy link
Member Author

/run-all-tests

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@siddontang
Copy link
Contributor

any update @overvenus

Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
Copy link
Member Author

/run-all-tests

@zhouqiang-cl
Copy link
Contributor

/run-integration-compatibility-test

@overvenus
Copy link
Member Author

/run-all-tests

@overvenus overvenus added component/gRPC Component: gRPC and removed component/build Component: Build, Deployment, etc. labels Jan 10, 2019
Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangjinpeng87 zhangjinpeng87 merged commit cb159cb into tikv:master Jan 11, 2019
@overvenus overvenus deleted the grpcio-0.4.2 branch January 11, 2019 03:45
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/gRPC Component: gRPC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants