Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

titan: avoid to hold global mutex while syncing titan manifest #15351

Closed
BornChanger opened this issue Aug 17, 2023 · 2 comments · Fixed by #15775 or #15914
Closed

titan: avoid to hold global mutex while syncing titan manifest #15351

BornChanger opened this issue Aug 17, 2023 · 2 comments · Fixed by #15775 or #15914
Assignees
@Connor1996
Labels
affects-6.1 affects-6.2 affects-6.3 affects-6.4 affects-6.5 affects-6.6 affects-7.0 affects-7.1 affects-7.2 affects-7.3 affects-7.4 affects-7.5 severity/major type/bug The issue is confirmed as a bug.

Comments

@BornChanger
Copy link
Contributor

Bug Report

What version of TiKV are you using?

6.5, 7.1 and master

What operating system and CPU are you using?

amd / arm

Steps to reproduce

Turn on Titan, and run writing workload.

What did you expect?

What did happened?

Global mutex slowed down the write speed.
@BornChanger BornChanger added the type/bug The issue is confirmed as a bug. label Aug 17, 2023
@BornChanger
Copy link
Contributor Author

/assign @Connor1996

@BornChanger BornChanger mentioned this issue Aug 17, 2023
Open
@Connor1996 Connor1996 mentioned this issue Aug 22, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Aug 22, 2023
@Connor1996
titan: update titan to avoid manifest mutex on release-6.5 (#15399)
926dc5a 
close #15351

update titan to avoid manifest mutex

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@tonyxuqqi
Copy link
Contributor

/check-pick release-7.1

@Connor1996 Connor1996 added type/enhancement The issue or PR belongs to an enhancement. type/bug The issue is confirmed as a bug. and removed type/bug The issue is confirmed as a bug. type/enhancement The issue or PR belongs to an enhancement. labels Oct 16, 2023
@Connor1996 Connor1996 mentioned this issue Oct 16, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Oct 17, 2023
@Connor1996 @tonyxuqqi
titan: update titan to avoid manifest mutex on release-7.1 (#15775)
4ec0906 
close #15351

update titan to avoid manifest mutex

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

Co-authored-by: tonyxuqqi <tonyxuqi@outlook.com>
@Connor1996 Connor1996 mentioned this issue Nov 3, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 3, 2023
@Connor1996
titan: update titan to avoid manifest io mutex (#15914)
e0fe14d 
close #15351

titan: update titan to avoid manifest io mutex

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 3, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Nov 7, 2023
@ti-chi-bot @Connor1996 @ti-chi-bot
titan: update titan to avoid manifest io mutex (#15914) (#15915)
5a307f1 
close #15351

titan: update titan to avoid manifest io mutex

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

Co-authored-by: Connor1996 <zbk602423539@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Connor1996 Connor1996

Labels
affects-6.1 affects-6.2 affects-6.3 affects-6.4 affects-6.5 affects-6.6 affects-7.0 affects-7.1 affects-7.2 affects-7.3 affects-7.4 affects-7.5 severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
4 participants
@jebter @tonyxuqqi @Connor1996 @BornChanger