Skip to content

Conversation

nyurik
Copy link

@nyurik nyurik commented May 25, 2025

No description provided.

Copy link

ti-chi-bot bot commented May 25, 2025

Welcome @nyurik! It looks like this is your first PR to tikv/pprof-rs 🎉

Signed-off-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>
CommanderStorm pushed a commit to maplibre/martin that referenced this pull request May 25, 2025
Criterion 0.6 is requiring tikv/pprof-rs#271 to
be released first
@YangKeao
Copy link
Member

Criterion requires rust 1.80 🤔. It'll need to bump the MSRV of pprof-rs. Let me think about it (we don't have a clear rule about bumping the MSRV for now 🤦 ).

@sunng87
Copy link

sunng87 commented Jun 20, 2025

Would be nice to do the bump. 1.80 is almost 1-year old. (just updated a few of my own libraries)

@GeeWee
Copy link

GeeWee commented Jul 1, 2025

I'd also love to see this merged so that we can upgrade criterion in our repositories :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants