Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TiDB Dashboard to v2021.07.17.1 [release-5.0] #3884

Conversation

tidb-dashboard-bot
Copy link
Contributor

@tidb-dashboard-bot tidb-dashboard-bot commented Jul 16, 2021

What problem does this PR solve?

Update TiDB Dashboard to v2021.07.17.1.

Upstream commit: pingcap/tidb-dashboard@2226872 .

Release note

TiDB Dashboard: Add OIDC based SSO support

Signed-off-by: tidb-dashboard-bot <tidb-dashboard-bot@pingcap.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Jul 16, 2021
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #3884 (114222f) into release-5.0 (09e8392) will decrease coverage by 0.00%.
The diff coverage is 96.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.0    #3884      +/-   ##
===============================================
- Coverage        74.73%   74.72%   -0.01%     
===============================================
  Files              245      245              
  Lines            24188    24208      +20     
===============================================
+ Hits             18076    18089      +13     
- Misses            4503     4505       +2     
- Partials          1609     1614       +5     
Flag Coverage Δ
unittests 74.72% <96.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/api/region.go 65.84% <96.15%> (+1.66%) ⬆️
tests/pdctl/helper.go 100.00% <100.00%> (ø)
server/election/leadership.go 83.52% <0.00%> (-3.53%) ⬇️
server/tso/allocator_manager.go 76.74% <0.00%> (-2.66%) ⬇️
server/tso/tso.go 71.77% <0.00%> (-2.46%) ⬇️
server/schedulers/shuffle_hot_region.go 52.63% <0.00%> (-2.11%) ⬇️
server/member/member.go 67.93% <0.00%> (-1.64%) ⬇️
server/schedule/operator/step.go 67.44% <0.00%> (-1.00%) ⬇️
server/grpc_service.go 46.94% <0.00%> (-0.23%) ⬇️
client/client.go 72.24% <0.00%> (+0.13%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fff28d...114222f. Read the comment docs.

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 17, 2021
@HunDunDM HunDunDM added the component/visualization Visualization. label Jul 17, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 17, 2021
@HunDunDM HunDunDM added this to the v5.0.4 milestone Jul 17, 2021
@HunDunDM HunDunDM added backport-5.0.4 require-LGT1 Indicates that the PR requires an LGTM. labels Jul 17, 2021
@HunDunDM
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 114222f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-5.0.4 cherry-pick-approved Cherry pick PR approved by release team. component/visualization Visualization. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants