Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schedule: fix the bug that the kind of role change operator is marked as OpRegion #3107

Merged
merged 7 commits into from
Oct 28, 2020
Merged

schedule: fix the bug that the kind of role change operator is marked as OpRegion #3107

merged 7 commits into from
Oct 28, 2020

Conversation

HunDunDM
Copy link
Member

@HunDunDM HunDunDM commented Oct 27, 2020 •
edited
Loading

What problem does this PR solve?

  • The operator generated by JointStateChecker cannot fail quickly when the target store is disconnected.

What is changed and how it works?

  • Do not mark the kind of role change (ChangePeerV2Enter, ChangePeerV2Leave) as OpRegion
  • Updated some naming and comments

Check List

Tests

  • Unit test

Release note

  • No release note

@HunDunDM
schedule: fix the bug that the kind of role change is marked as OpRegion
364143e 
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
@HunDunDM
update comment
72fbf64 
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
@HunDunDM
update comment
dd440cf 
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
@HunDunDM
update test
6a325ec 
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
@HunDunDM
update test
8819999 
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
@HunDunDM HunDunDM added the component/schedule Scheduling logic. label Oct 27, 2020
@HunDunDM HunDunDM self-assigned this Oct 27, 2020
@HunDunDM
fix
91a9777 
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
@HunDunDM HunDunDM mentioned this pull request Oct 27, 2020
Closed
37 tasks
@HunDunDM
Copy link
Member Author

/run-all-tests

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 28, 2020
nolouch
nolouch reviewed Oct 28, 2020
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 28, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 28, 2020
@nolouch
Copy link
Contributor

nolouch commented Oct 28, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 28, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 52f5010 into tikv:master Oct 28, 2020
@HunDunDM HunDunDM deleted the op-kind branch October 28, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch left review comments

@disksing disksing disksing approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees

@HunDunDM HunDunDM

Labels
component/schedule Scheduling logic. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HunDunDM @nolouch @ti-srebot @disksing