Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel LoadRegionsOnce when exits WatchLeader #3936

Closed
disksing opened this issue Aug 2, 2021 · 2 comments · Fixed by #4175
Closed

Cancel LoadRegionsOnce when exits WatchLeader #3936

disksing opened this issue Aug 2, 2021 · 2 comments · Fixed by #4175
Assignees
@disksing
Labels
affects-4.0 affects-5.0 affects-5.1 affects-5.2 severity/major status/TODO The issue will be done in the future. type/bug The issue is confirmed as a bug.

Comments

@disksing
Copy link
Contributor

disksing commented Aug 2, 2021 •
edited
Loading

Bug Report

When the PD starts, if there is a leader (or if all PDs restart at the same time and etcd still has the leader key left over from the restart), the PD enters the follower state and loads the region from the region storage and starts the region syncer client to synchronize the region.
If all PDs are restarted at the same time, or if the old leader steps down, the newly started PD cannot start the election until the region is loaded.

What version of PD are you using (pd-server -V)?

master
@disksing disksing added the type/bug The issue is confirmed as a bug. label Aug 2, 2021
@mayjiang0203
Copy link

mayjiang0203 commented Aug 5, 2021 •
edited
Loading

/remove-severity Moderate
/severity Major
/assign @disksing

@disksing disksing self-assigned this Aug 5, 2021
@ti-chi-bot
Copy link
Member

@mayjiang0203: These labels are not set on the issue: severity/moderate.

In response to this:

/remove-severity Moderate
/severity Major
/assign @disksing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nolouch nolouch added the status/TODO The issue will be done in the future. label Sep 26, 2021
@disksing disksing mentioned this issue Sep 28, 2021
Merged
This was referenced Oct 19, 2021
Merged
Merged
Merged
Merged
disksing added a commit to ti-chi-bot/pd that referenced this issue Oct 20, 2021
@disksing
fix compile
2f52497 
ref tikv#3936

Signed-off-by: disksing <i@disksing.com>
ti-chi-bot added a commit that referenced this issue Nov 24, 2021
@ti-chi-bot @disksing @nolouch
core: allow cancel load region (#4175) (#4219)
ae08ed0 
* This is an automated cherry-pick of #4175

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* resolve conflicts

Signed-off-by: disksing <i@disksing.com>

* fix compile

ref #3936

Signed-off-by: disksing <i@disksing.com>

* fix test

Signed-off-by: disksing <i@disksing.com>

* fix build

Signed-off-by: disksing <i@disksing.com>

Co-authored-by: disksing <i@disksing.com>
Co-authored-by: ShuNing <nolouch@gmail.com>
@nolouch nolouch added needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 labels Dec 21, 2021
@nolouch nolouch added affects-4.0 affects-5.0 affects-5.1 and removed needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@disksing disksing

Labels
affects-4.0 affects-5.0 affects-5.1 affects-5.2 severity/major status/TODO The issue will be done in the future. type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: allow cancel load region oh-my-tidb/pd
4 participants
@nolouch @mayjiang0203 @disksing @ti-chi-bot