Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer role should be string instead of number #3372

Closed
BusyJay opened this issue Jan 20, 2021 · 3 comments · Fixed by #3643
Closed

Peer role should be string instead of number #3372

BusyJay opened this issue Jan 20, 2021 · 3 comments · Fixed by #3643
Assignees
Labels
severity/moderate type/enhancement The issue or PR belongs to an enhancement.

Comments

@BusyJay
Copy link
Member

BusyJay commented Jan 20, 2021

Bug Report

What did you do?

Enable joint consensus and check some region in joint state

What did you expect to see?

Peers show with exact role name.

What did you see instead?

Peers with role set to number:

{
  "id": 5995753,
  "store_id": 8,
  "role": 2
}

What version of PD are you using (pd-server -V)?

Nightly

@HunDunDM
Copy link
Member

HunDunDM commented Apr 7, 2021

Modification from kvproto has some impact and may introduce compatibility issues.

@Yisaer Yisaer added the type/enhancement The issue or PR belongs to an enhancement. label Apr 9, 2021
@HunDunDM HunDunDM removed the type/bug The issue is confirmed as a bug. label Apr 16, 2021
@HunDunDM
Copy link
Member

Is it ok to only adjust the output of pd-ctl?

@BusyJay
Copy link
Member Author

BusyJay commented Apr 23, 2021

It may be another problem that output of pd-ctl is not consistent with curl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/moderate type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants