check transaction response in store

rename variable `receiver` into
`globalConfigWatcherCH` due to it cause ambiguity of variable meaning

Signed-off-by: lemonhx <lemonhx@lemonhx.tech>

Author: LemonHX

client/client.go

@@ -1801,23 +1801,23 @@ func (c *client) StoreGlobalConfig(ctx context.Context, items []GlobalConfigItem
 }
 
 func (c *client) WatchGlobalConfig(ctx context.Context) (chan []GlobalConfigItem, error) {
-	receiver := make(chan []GlobalConfigItem, 16)
+	globalConfigWatcherCh := make(chan []GlobalConfigItem, 16)
 	res, err := c.getClient().WatchGlobalConfig(ctx, &pdpb.WatchGlobalConfigRequest{})
 	if err != nil {
-		close(receiver)
+		close(globalConfigWatcherCh)
 		return nil, err
 	}
 	go func() {
 		defer func() {
 			if r := recover(); r != nil {
-				log.Error("[pd] panic in client `WatchGlobalConfig` cause by", zap.Any("error:", r))
+				log.Error("[pd] panic in client `WatchGlobalConfig`", zap.Any("error", r))
 				return
 			}
 		}()
 		for {
 			select {
 			case <-ctx.Done():
-				close(receiver)
+				close(globalConfigWatcherCh)
 				return
 			default:
 				m, err := res.Recv()
@@ -1828,9 +1828,9 @@ func (c *client) WatchGlobalConfig(ctx context.Context) (chan []GlobalConfigItem
 				for j, i := range m.Changes {
 					arr[j] = GlobalConfigItem{i.GetName(), i.GetValue(), nil}
 				}
-				receiver <- arr
+				globalConfigWatcherCh <- arr
 			}
 		}
 	}()
-	return receiver, err
+	return globalConfigWatcherCh, err
 }

server/grpc_service.go

@@ -1711,11 +1711,14 @@ func (s *GrpcServer) StoreGlobalConfig(ctx context.Context, request *pdpb.StoreG
 		value := item.GetValue()
 		ops[i] = clientv3.OpPut(name, value)
 	}
-	_, err :=
+	res, err :=
 		kv.NewSlowLogTxn(s.client).Then(ops...).Commit()
 	if err != nil {
 		return &pdpb.StoreGlobalConfigResponse{Error: &pdpb.Error{Type: pdpb.ErrorType_UNKNOWN, Message: err.Error()}}, err
 	}
+	if !res.Succeeded {
+		return &pdpb.StoreGlobalConfigResponse{Error: &pdpb.Error{Type: pdpb.ErrorType_UNKNOWN, Message: "failed to execute StoreGlobalConfig transaction"}}, errors.Errorf("failed to execute StoreGlobalConfig transaction")
+	}
 	return &pdpb.StoreGlobalConfigResponse{}, err
 }
 
@@ -1773,7 +1776,6 @@ func (s *GrpcServer) WatchGlobalConfig(request *pdpb.WatchGlobalConfigRequest, s
 func (s *GrpcServer) sendAllGlobalConfig(ctx context.Context, server pdpb.PD_WatchGlobalConfigServer) error {
 	configList, err := s.client.Get(ctx, globalConfigPath, clientv3.WithPrefix())
 	if err != nil {
-		log.Error("get global config from etcd failed", zap.Error(err))
 		return err
 	}
 	ls := make([]*pdpb.GlobalConfigItem, configList.Count)