Skip to content

Commit 29a8db6

Browse files
committed
add unit test
Signed-off-by: bufferflies <1045931706@qq.com>
1 parent 66fb908 commit 29a8db6

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

server/cluster/cluster.go

-1
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ type RaftCluster struct {
100100
core *core.BasicCluster
101101
meta *metapb.Cluster
102102
opt *config.PersistOptions
103-
cfg *config.Config
104103
storage storage.Storage
105104
id id.Allocator
106105
limiter *StoreLimiter

server/config/config_test.go

+3
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ func (s *testConfigSuite) TestReloadConfig(c *C) {
9191
}
9292
c.Assert(newOpt.GetMaxReplicas(), Equals, 5)
9393
c.Assert(newOpt.GetMaxSnapshotCount(), Equals, uint64(10))
94+
c.Assert(newOpt.GetCfg().MaxRegionSize, Equals, uint64(defaultMaxRegionSize))
9495
}
9596

9697
func (s *testConfigSuite) TestReloadUpgrade(c *C) {
@@ -166,6 +167,7 @@ func (s *testConfigSuite) TestAdjust(c *C) {
166167
name = ""
167168
lease = 0
168169
max-request-bytes = 20000000
170+
max-region-size = 10000
169171
170172
[pd-server]
171173
metric-storage = "http://127.0.0.1:9090"
@@ -187,6 +189,7 @@ leader-schedule-limit = 0
187189
c.Assert(cfg.Name, Equals, fmt.Sprintf("%s-%s", defaultName, host))
188190
c.Assert(cfg.LeaderLease, Equals, defaultLeaderLease)
189191
c.Assert(cfg.MaxRequestBytes, Equals, uint(20000000))
192+
c.Assert(cfg.MaxRegionSize, Equals, uint64(10000))
190193
// When defined, use values from config file.
191194
c.Assert(cfg.Schedule.MaxMergeRegionSize, Equals, uint64(0))
192195
c.Assert(cfg.Schedule.EnableOneWayMerge, IsTrue)

server/schedule/checker/merge_checker_test.go

+6
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,12 @@ func (s *testMergeCheckerSuite) TestBasic(c *C) {
113113
c.Assert(ops[0].RegionID(), Equals, s.regions[2].GetID())
114114
c.Assert(ops[1].RegionID(), Equals, s.regions[1].GetID())
115115

116+
// change the max region size
117+
s.cluster.GetCfg().MaxRegionSize = 200
118+
s.cluster.PutRegion(s.regions[1].Clone(core.SetApproximateSize(200)))
119+
ops = s.mc.Check(s.regions[2])
120+
c.Assert(ops, NotNil)
121+
s.cluster.GetCfg().MaxRegionSize = 96
116122
// Test the peer store check.
117123
store := s.cluster.GetStore(1)
118124
c.Assert(store, NotNil)

0 commit comments

Comments
 (0)