Docker compatibility using a Dockerfile #9

random-robbie · 2017-10-25T09:05:44Z

Working docker container.

docker build -t acstis .
docker run -it acstis:latest

Working docker container. ``` docker build -t acstis . docker run -it acstis:latest ```

tijme · 2017-10-25T10:19:59Z

Really awesome to get a pull request from you 😄, thank you for contributing !

I'm not using Docker myself but I checked out the documentation and found a deprecation notice that applies to this pull request.

Maintainer Label
https://docs.docker.com/engine/reference/builder/#maintainer-deprecated

I think this should now be LABEL maintainer="txt3rob@gmail.com"

Please correct me if I'm wrong.

random-robbie

updated the label

random-robbie · 2017-10-25T11:21:00Z

Hey dude,

Updated it now.

works wonders in docker.

tijme · 2017-10-25T11:44:03Z

Thanks again for your contribution. I just merged the Docker file to the master branch 😄 .

random-robbie · 2017-10-25T15:06:56Z

👍 brilliant hopefully it helps others get it up and running.

Create Dockerfile

745bb1a

Working docker container. ``` docker build -t acstis . docker run -it acstis:latest ```

tijme added the Feature label Oct 25, 2017

tijme assigned tijme and unassigned tijme Oct 25, 2017

tijme requested review from tijme and removed request for tijme October 25, 2017 10:21

Update Dockerfile

1c254d6

random-robbie commented Oct 25, 2017

View reviewed changes

tijme merged commit 394791e into tijme:master Oct 25, 2017

tijme changed the title ~~Create Dockerfile~~ Docker compatibility using a Dockerfile Oct 28, 2017

Provide feedback