Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dark mode buttons fit for dark mode #1827

Open
tijlleenders opened this issue Feb 6, 2024 · 4 comments
Open

Make dark mode buttons fit for dark mode #1827

tijlleenders opened this issue Feb 6, 2024 · 4 comments
Labels
design enhancement New feature or request UI User-Interface

Comments

@tijlleenders
Copy link
Owner

Is your feature request related to a problem? Please describe.
It's very annoying when you're in dark mode and the buttoms are not compatible / readable.

Describe the solution you'd like
Find a better design.
Validate that with team.
Implement it.

Describe alternatives you've considered
None.

Additional context
36_DuckDuckGo.jpg

326_DuckDuckGo.jpg

4409_DuckDuckGo.jpg

0206_064512_DuckDuckGo.jpg

@tijlleenders tijlleenders added design enhancement New feature or request UI User-Interface labels Feb 6, 2024
@tijlleenders tijlleenders moved this to temp to drag faster in ZinZen® Feb 6, 2024
@tijlleenders tijlleenders moved this from temp to drag faster to Parking lot in ZinZen® Feb 7, 2024
@vinaybadgujar102
Copy link
Collaborator

@tijlleenders, we can opt for a darker version of the color.

Screenshot from 2024-03-07 14-56-21

@vinaybadgujar102 vinaybadgujar102 self-assigned this Mar 7, 2024
@tijlleenders
Copy link
Owner Author

Is that just a one-line change?

Please use a contrast checker to see if it conforms to accessibility guidelines.

@vinaybadgujar102
Copy link
Collaborator

vinaybadgujar102 commented Mar 8, 2024

Is that just a one-line change?

Yeah it will be one line change.

What about other themes?

@tijlleenders
Copy link
Owner Author

Cool, we can do that then. It looks good.

Just make sure the contrast levels of all themes are conform accessibility standards.

@vinaybadgujar102 vinaybadgujar102 moved this from Parking lot to In progress in ZinZen® Mar 17, 2024
@tijlleenders tijlleenders moved this from In progress to low prio in ZinZen® Mar 29, 2024
@vinaybadgujar102 vinaybadgujar102 removed their assignment Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement New feature or request UI User-Interface
Projects
Status: low prio
Development

No branches or pull requests

2 participants