Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner)!: add ego pose consideration (#5036) #942

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

yuki-takagi-66
Copy link

@yuki-takagi-66 yuki-takagi-66 commented Oct 13, 2023

hotfix of autowarefoundation#5036

https://star4.slack.com/archives/C022RLPU1PZ/p1697016552543899?thread_ts=1696573047.550449&cid=C022RLPU1PZ

  • feat: add the feature to consider the current ego position

  • feat: add ego pose consideration. Both the lateral error and the yaw error are assumed to decrease to zero by a specified constant time (e.g 1.5 second).

  • feat: (continue) implement parameter settings for "cosider-current-ego-pose"

  • cleaned up the code

  • change description of the parameters

  • align format

  • Update planning/obstacle_cruise_planner/include/obstacle_cruise_planner/node.hpp

  • Update planning/obstacle_cruise_planner/src/node.cpp


Note: Confirm the contribution guidelines before submitting a pull request.

Click the Preview tab and select a PR template:

Do NOT send a PR with this description.

…oundation#5036)

* feat: add the feature to consider the current ego position

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* feat: add ego pose consideration. Both the lateral error and the yaw error are assumed to decrease to zero by a specified constant time (e.g 1.5 second).

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* feat: (continue) implement parameter settings for "cosider-current-ego-pose"

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* cleaned up the code

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* change description of the parameters

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* align format

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* Update planning/obstacle_cruise_planner/include/obstacle_cruise_planner/node.hpp

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

* Update planning/obstacle_cruise_planner/src/node.cpp

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

---------

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review October 13, 2023 10:53
Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit d34000e into beta/v0.10.2 Oct 13, 2023
15 of 16 checks passed
@shmpwk shmpwk deleted the beta/v0.10.2+f7a1b16 branch October 13, 2023 16:03
tkimura4 pushed a commit that referenced this pull request Oct 16, 2023
…oundation#5036) (#942)

* feat: add the feature to consider the current ego position



* feat: add ego pose consideration. Both the lateral error and the yaw error are assumed to decrease to zero by a specified constant time (e.g 1.5 second).



* feat: (continue) implement parameter settings for "cosider-current-ego-pose"



* cleaned up the code



* change description of the parameters



* align format



* Update planning/obstacle_cruise_planner/include/obstacle_cruise_planner/node.hpp



* Update planning/obstacle_cruise_planner/src/node.cpp



---------

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants