Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): safety check improvement #819

Merged

Conversation

satoshi-ota
Copy link

@satoshi-ota satoshi-ota commented Sep 11, 2023

Description

回避
回避キャンセルが過敏
右折ルートスタート直後の回避
テレコムセンター前交差点右折後路駐車回避(動画 4:06~)
@Tomoya Kimura
cc
@shiori kawata(OST)
上記FBに対するコメントです。やっぱりv0.42.0.0と比較しても回避キャンセルが過敏になっていそうですね。場合によってはv0.43.1.0でcherry pickする予定だったhotfixを前倒しでv0.43.0.0に入れるのも検討してもいいのかもしれません。

Related links

https://star4.slack.com/archives/CEV8XMJBV/p1694565649818809?thread_ts=1694164812.546249&cid=CEV8XMJBV

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

satoshi-ota and others added 5 commits September 11, 2023 10:50
…ation#4754)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…owarefoundation#4762)

perf(safety_check): use light weight object position check

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…warefoundation#4735)

* feat(safety_check): add hysteresis factor

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(lane_change): add hysteresis factor

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): add hysteresis factor

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): add time series hysteresis

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota changed the title Hotfix/avoidance safety check hotfix(avoidance): safety check improvement Sep 13, 2023
@tkimura4 tkimura4 marked this pull request as ready for review September 13, 2023 02:31
@tkimura4 tkimura4 enabled auto-merge September 13, 2023 02:34
@tkimura4 tkimura4 changed the title hotfix(avoidance): safety check improvement feat(avoidance): safety check improvement Sep 13, 2023
@tkimura4 tkimura4 merged commit 0351eb8 into tier4:beta/v0.10.0 Sep 13, 2023
@satoshi-ota satoshi-ota deleted the hotfix/avoidance-safety-check branch September 14, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants