feat: apply pose_instability_risk to localization_diag #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
上記について、errorが出力される事のチェックはどのPRで確認しているか教えて下さい。 |
Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
|
2af2fe0 ※diagnostic_aggregatorにて既存のlane_departure監視項目との名称部分一致が発生してしまったため、これを回避する目的 |
正しくOK/ERRORが出力されることの検証は、https://github.com/tier4/pose_instability_risk_monitor/pull/5 の範疇となります！ |
|
sfukuta
approved these changes
Oct 1, 2024
7 tasks
yn-mrse
added a commit
that referenced
this pull request
Oct 30, 2024
1222-takeshi
added a commit
that referenced
this pull request
Nov 15, 2024
* fix spline bug Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * revert: "feat: apply pose_instability_risk to localization_diag" (#1613) Revert "feat: apply pose_instability_risk to localization_diag (#1560)" This reverts commit 4bcb436. * revert: "feat(lane_departure_checker): add parameter of footprint_extra_margin" (#1614) Revert "feat(lane_departure_checker): add parameter of footprint_extra_margin…" This reverts commit 0245366. --------- Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> Co-authored-by: Y.Hisaki <yhisaki31@gmail.com> Co-authored-by: Yuma Nihei <yuma.nihei@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
本PRは「自己位置推定が大きくずれる前に停車する機能」を実現するため、
localizationの監視項目として下記2項目をMRMの対象項目として定義するものである。
本設定により、system_error_monitorにて上記項目を認識できる状態となる。
また、各監視項目にはタイムアウトが設定できるようになっている。
出力周期が10Hzであることを考慮し、可用性を維持できると考えられる0.3secに設定する。
なお当該設計方針は設計書に明記されている。
Related links
How was this PR tested?
■監視項目の追加
diagnostics_aggregatorの出力結果に
の2項目が認識されていることを確認済み。
■途絶検出
pose_instability_risk_monitorのprocess killおよびタイムアウトにより、STALEを検出できることを確認済み。
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.