Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object_lanelet_filter, vector_map_inside_area_filter): cherry-pick unknown removal feature from awf #1327

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

YoshiRi
Copy link

@YoshiRi YoshiRi commented Jun 7, 2024

Description

AWFに追加済みのUnknownの除去ロジックの一部をcherry-pickします。
これが入ることでロータリのカーブの縁石Unknownが正しく除去できるようになります。

追加される機能一覧

  • object_lanelet_filter:
    • Lane外の点群のみで構成されたUnknownがLanelet Filterで弾けない問題を解決
  • vector_map_inside_area_filter:
    • mapに設定した領域内の点群を除去するフィルタにて高さを考慮できるように変更(非低層点群を誤って消さないようにする)
    • このPR単体では全体としては不使用

関連するPR

Related links

Universe PR

Tests performed

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@badai-nguyen
Copy link

@YoshiRi Cherry-pick したAWFのPRをもDescriptionとかに記入していただけますか?

@0x126 0x126 merged commit 4388a51 into beta/v0.19.1 Jun 11, 2024
15 of 17 checks passed
@0x126 0x126 deleted the feat/update_object_lanelet_filter_x2 branch June 11, 2024 04:27
@YoshiRi
Copy link
Author

YoshiRi commented Jun 11, 2024

cherry-pick元をRelated Linksに貼っておきました。これらのPRは全てAWFからのImportなのでversionが追いつけば自動で取り込まれます。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants