Skip to content

Commit 3c4744a

Browse files
authored
Merge pull request #1557 from TimTaylor/patch-as_tibble
2 parents e78ea46 + 9a6911b commit 3c4744a

File tree

6 files changed

+451
-107
lines changed

6 files changed

+451
-107
lines changed

R/as_tibble.R

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,10 @@ as_tibble.data.frame <- function(x, validate = NULL, ...,
7474
deprecate_stop("2.0.0", "tibble::as_tibble(validate = )", "as_tibble(.name_repair =)")
7575
}
7676

77+
if (!inherits(x, "tbl_df") && !identical(class(x), "data.frame")) {
78+
x <- as.data.frame(x)
79+
}
80+
7781
old_rownames <- raw_rownames(x)
7882
if (is.null(.rows)) {
7983
.rows <- nrow(x)

revdep/README.md

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,24 @@
11
# Revdeps
22

3-
## New problems (2)
3+
## Failed to check (11)
4+
5+
|package |version |error |warning |note |
6+
|:----------------|:-------|:-----|:-------|:----|
7+
|bulkreadr |? | | | |
8+
|dplyr |? | | | |
9+
|historicalborrow |? | | | |
10+
|LexisNexisTools |? | | | |
11+
|matrixset |? | | | |
12+
|NMsim |? | | | |
13+
|RevGadgets |? | | | |
14+
|simaerep |? | | | |
15+
|simTool |? | | | |
16+
|tidyposterior |? | | | |
17+
|workflowsets |? | | | |
18+
19+
## New problems (1)
420

521
|package |version |error |warning |note |
622
|:-------|:-------|:------|:-------|:----|
7-
|[ggESDA](problems.md#ggesda)|0.2.0 |__+1__ |__+1__ | |
8-
|[RSDA](problems.md#rsda)|3.0.13 |__+1__ |__+1__ | |
23+
|[NMdata](problems.md#nmdata)|0.1.2 |__+1__ | | |
924

revdep/cran.md

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,15 @@
11
## revdepcheck results
22

3-
We checked 14 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
3+
We checked 14 reverse dependencies (3 from CRAN + 11 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
44

5-
* We saw 2 new problems
5+
* We saw 1 new problems
66
* We failed to check 0 packages
77

88
Issues with CRAN packages are summarised below.
99

1010
### New problems
1111
(This reports the first line of each new failure)
1212

13-
* ggESDA
14-
checking examples ... ERROR
15-
checking re-building of vignette outputs ... WARNING
16-
17-
* RSDA
18-
checking examples ... ERROR
19-
checking re-building of vignette outputs ... WARNING
13+
* NMdata
14+
checking tests ... ERROR
2015

0 commit comments

Comments
 (0)