Eliminate vctrs::vec_cast_list() #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
approved these changes
Sep 26, 2022
| stopifnot(is_cluster(cluster)) | ||
| code <- enexpr(code) | ||
| to_rm <- attr(cluster, "cleaner")$reset() | ||
|
|
||
|
|
||
| if (!isTRUE(simplify) && !is.null(ptype)) { |
There was a problem hiding this comment.
Maybe take simplify = NULL and use a different default depending on whether ptype is supplied? If not supplied, defaults to FALSE. If supplied, defaults to TRUE.
Do we want to generally support simplify = NA for consistency with purrr?
There was a problem hiding this comment.
I think we want to move this interface towards list_simplify() so I'd prefer some warning here.
But you're right that I should I support simplify = NA in order to match the interface exactly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136