Skip to content

🐛 Avoid mapping AsIs variables to mapped_discrete class in discrete scales #6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #6308.

From #6308 (comment):

Where the scale maps AsIs variables to the <mapped_discrete> class, thereby skipping the rescale.AsIs method.

This PR no longer maps AsIs variables to the <mapped_discrete> class.

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit ef9d417 into tidyverse:main Mar 25, 2025
13 checks passed
@teunbrand teunbrand deleted the fix_6308 branch March 25, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The I function does not work as expected on categorical y axis and numeric x axis
2 participants