Skip to content

Bump deprecations #6138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 25, 2025
Merged

Bump deprecations #6138

merged 14 commits into from
Mar 25, 2025

Conversation

teunbrand
Copy link
Collaborator

@teunbrand teunbrand commented Oct 15, 2024

This PR does not fix an issue, but I see it as regular maintenance.

Briefly, it converts deprecate_warn0() to lifecycle::deprecate_stop() for functions/arguments that were deprecated prior to ggplot 3.3.0.
It converts deprecate_soft0() to deprecate_warn0() for functions/arguments that were deprecated up to ggplot2 3.2.0 and removes examples.

I thought 5 years to be an OK horizon for deprecation warnings and I felt it was time to stop allowing things from the previous major version. Happy to make these timelines shorter though :)

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a revdepcheck for this before we fully commit. I agree in principle about the timespan

@thomasp85
Copy link
Member

revdepchecks have been committed

@teunbrand
Copy link
Collaborator Author

teunbrand commented Jan 27, 2025

So about 30/347 packages show up with at least a deprecation warning. This comes with the caveat that we only see warnings when something else is wrong too: I don't think throwing a warning includes a package in the problems section.

I think we might be slightly too aggressive about erroring on the theme settings, as giving a wrong argument usually gives a warning, not an error. Honestly I'm kind of baffled that some packages still use arguments that were deprecated since ggplot2 2.0.0 (i.e. 10 years ago).

@teunbrand
Copy link
Collaborator Author

Per #6281 (comment):

I think we are at the point were we can start a deprecation process. We already have deprecation warnings for default_aes to alert extension developers and 2 years in I think we can begin to make noise for the users

Regarding size to linewidth translation

@thomasp85
Copy link
Member

Do you want another revdepcheck for this?

@teunbrand
Copy link
Collaborator Author

teunbrand commented Mar 25, 2025

For this specifically: not really. I think we're the right amount of agressive with these now and if we aren't: it'll show up on future revdepchecks we might run for other issues too.

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit d2cf9db into tidyverse:main Mar 25, 2025
13 checks passed
@teunbrand teunbrand deleted the bump_deprecations branch March 25, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants