Fix missing labels slot
#6010
Merged
Fix missing labels slot
#6010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasp85
reviewed
Aug 22, 2024
|
I wouldn't mark this as vestigial. It doesn't track layers anymore, but it still keeps labels if users use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix part of #6008.
Briefly, reverse dependencies sometimes make assumptions about
length(ggplot())ornames(ggplot()). In #5879 we removed thelabelsfield, causing these assumptions to no longer hold. This PR brings back thelabelsfield to make these assumptions valid again.