annotate()
gives warning when passing position
or stat
#5746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5151.
Briefly,
annotate()
is hardcoded to useStatIdentity
andPositionIdentity
so anystat
orposition
argument toannotate()
ends up in theparams
to the layer. This PR warns about such cases and pre-emptively removes these arguments.Demo:
Created on 2024-03-05 with reprex v2.1.0