Avoid bounded density discontinuity #5642
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5641.
Briefly, the way bounded densities were estimated may result in discontinuities due to incomplete estimation of the tails.
As densities are 'mirrored' across finite bounds, in this PR we ensure that the 'mirror image' is the same size as the original by multiplying the
to
/from
range in density estimation. We also increasen
to not lose any detail in the bounded density.The reprex from #5641 with this PR now shows a flatter line in the uniform density:
Created on 2024-01-15 with reprex v2.0.2