Skip to content

Flipped crossbar and boxplot keys #5083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 6, 2023
Merged

Flipped crossbar and boxplot keys #5083

merged 5 commits into from
Jan 6, 2023

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #5082.

In brief, key drawing function no longer rely on viewport rotations but instead hardcode two paths for (un)flipped directions. A visual test is affected, but not in a way that makes it glaringly worse.

@teunbrand teunbrand mentioned this pull request Dec 5, 2022
Closed
@teunbrand teunbrand added this to the ggplot2 3.4.1 milestone Jan 5, 2023
thomasp85
thomasp85 approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the changes in the visual test is only because the graphic device renders rectangles with rotation as polygons so the sag tag ends up being different because you forego any rotation in the fix

@teunbrand teunbrand merged commit 9468b69 into tidyverse:main Jan 6, 2023
@teunbrand teunbrand deleted the boxplot_key branch January 6, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

guide_legend() label.position = "bottom" mess up the theme() legend.key.size option
2 participants
@teunbrand @thomasp85