Restore names of guides after setup_panel_guides() #5064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutannihilation
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Thanks! Sorry, this was my fault on implementing #3972.
This looks good to me. Do you think this is worth a NEWS item? If so, could you add one to NEWS.md?
|
All good! Added a line to |
Co-authored-by: Hiroaki Yutani <yutani.ini@gmail.com>
Thanks for picking that up! |
yutannihilation
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5063
This fixes the names of aesthetics being dropped by
intersect()by moving the assigning of names until after theintersect()call.