Allow scale_{x/y}_sqrt() to have breaks at 0.
#4775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the release of the new {scales} version, this PR is now ready for your perusal. The failing check appears, to my untrained eyes, unrelated to the code in this PR. |
|
Can I get you to add a NEWS bullet? |
|
Of course, apologies for not including it in the first place! |
hadley
requested changes
Apr 19, 2022
NEWS.md
Outdated
| * `aes()` now supports the `!!!` operator in its first two arguments | ||
| (#2675). Thanks to @yutannihilation and @teunbrand for draft | ||
| implementations. | ||
|
|
||
| * Require rlang >= 1.0.0 (@billybarc, #4797) | ||
|
|
||
|
|
There was a problem hiding this comment.
Could you please remove this spurious diff?
hadley
approved these changes
Apr 20, 2022
This was referenced May 26, 2022
thomasp85
pushed a commit
that referenced
this pull request
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for submitting a PR that will not work (yet). It aims to fix #980.
In anticipation of r-lib/scales#336, this PR implements (a version of) the fix suggested here that has become viable thanks to the change in {scales}.
Note that this PR will likely not pass the automated checks until the new {scales} version hits CRAN, at which point is seems a good idea to bump the required version in the description file.