Skip to content

Workflow updates #4747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 3, 2022
Merged

Workflow updates #4747

merged 8 commits into from
Mar 3, 2022

Conversation

hadley
Copy link
Member

@hadley hadley commented Mar 2, 2022

No description provided.

@yutannihilation
Copy link
Member

Does this supersede #4697?

@yutannihilation
Copy link
Member

It seems so, thanks!

Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Note that, checks on Ubuntu runner will probably keep failing because it fails to install sf (c.f. r-spatial/sf#1899). I thought this would be resolved soon, but we might need to consider installing the dev version for now.

@thomasp85
Copy link
Member

@yutannihilation has had more experience with the actions for ggplot2 so I'll refer to him and his comments for review

@yutannihilation
Copy link
Member

Hmm, I haven't seen this error. It seems the change was made recently, but I have no idea what's happening... rstudio/rmarkdown@9d35270

could not find function "pandoc_math_engines"

(https://github.com/tidyverse/ggplot2/runs/5409764795?check_suite_focus=true)

@hadley
Copy link
Member Author

hadley commented Mar 3, 2022

The pandoc_math_engines is a regression in rmarkdown 2.12, is unrelated to this PR, and a fix is in flight. So @yutannihilation if you're ok with it, I think this PR is good to merge.

@yutannihilation
Copy link
Member

Thanks. Then, this should be good to merge now.

@hadley hadley merged commit ec8a917 into main Mar 3, 2022
@hadley hadley deleted the workflow-updates branch March 3, 2022 23:45
schloerke added a commit to schloerke/ggplot2 that referenced this pull request Mar 23, 2022
* master: (320 commits)
  Orientation-aware key glyphs (tidyverse#4757)
  Fix warning in geom_violin with draw_quantiles (tidyverse#4654)
  Fix misalignment in geom_dotplot when stackratio != 1 and stackdir != "up" (tidyverse#4734)
  Replace coord_equal in scale-identity.r (tidyverse#4759)
  Unified message format in `geom_smooth()` (tidyverse#4634)
  Add parentheses to mentions of binned_scale in scale-alpha and scale-viridis documentation (tidyverse#4735)
  Update geom-boxplot.r (tidyverse#4744)
  Remove unneeded backslash from diamonds docs (tidyverse#4711)
  Re-document
  Warn on unsupported geoms in annotate() (tidyverse#4721)
  Re-document
  Add Trump to presidential terms dataset (tidyverse#4702)
  Corrects bins / binwidth override documentation (tidyverse#4720)
  Update infrastructure to new best practices (tidyverse#4748)
  remove stringsAsFactor for the mapped_discrete as.data.frame method (tidyverse#4750)
  Workflow updates (tidyverse#4747)
  Ensure output is numeric even if ifelse clause is NA (tidyverse#4692)
  Add non_missing_aes to geom_tile (tidyverse#4683)
  Pass on binwidth and height to geom (tidyverse#4671)
  Check for range == NULL - happens if no data has been added to plot (tidyverse#4682)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants