Skip to content

Do not pass bg arg to grDevices::win.metafile() #4523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2021
Merged

Do not pass bg arg to grDevices::win.metafile() #4523

merged 1 commit into from
Jun 22, 2021

Conversation

yutannihilation
Copy link
Member

Fix #4521

#4164 adds bg arg to ggsave(), but grDevices::win.metafile() is the exception in that it doesn't have bg argument. We need to absorb it in the wrapper function.

@yutannihilation yutannihilation mentioned this pull request Jun 22, 2021
Closed
@thomasp85 thomasp85 changed the base branch from master to v3.3.5-rc June 22, 2021 08:14
@thomasp85 thomasp85 merged commit 59be694 into tidyverse:v3.3.5-rc Jun 22, 2021
@thomasp85
Copy link
Member

Merged into v3.3.5-rc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clauswilke clauswilke clauswilke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ggsave error with emf and wmf "grDevices::win.metafile(...) : unused argument (bg = "white")"
3 participants
@yutannihilation @thomasp85 @clauswilke